[Mlir-commits] [mlir] [mlir][tosa] Add F32 to F16 type narrowing pass (PR #218900)

[Luke Hutton]

https://github.com/lhutton1 commented:

Thanks for proposing this new pass, overall the approach seems good to me. 

My main concern would be users of such a pass. I can see this pass being useful for applications such as exploration/benchmarking where correctness doesn't necessarily need to be maintained. Using this in model conversion pipelines seems more risky since a user may not be aware of it running. I've suggested to add more information to the description covering this, though I wonder if this will be enough.

Tagging some others who may be interested: @Lallapallooza @Tessil @sahas3 

https://github.com/llvm/llvm-project/pull/218900