[Mlir-commits] [mlir] [mlir][vector] Promote in-bounds sub-vector transfer reads with Mem2Reg (PR #236320)
Federico Bruzzone
llvmlistbot at llvm.org
Sat Oct 31 03:33:34 PDT 2026
================
----------------
FedericoBruzzone wrote:
You might want to familiarize yourself with the [MLIR Testing guidelines](https://mlir.llvm.org/getting_started/TestingGuide/).
In general:
1. There are lots of negative tests here. please `negative_*` them
2. For subview: `subview_{static | dynamic}_*`
3. We can name the reason, for instance, `*_static_bounds`
4. `whole_*` should be something like `whole_buffer_*`
5. `partial_read_masked` and `partial_read_loop` should mirror `read_with_mask` and `whole_buffer_in_loop`
And do on.
Thank you 🙏
https://github.com/llvm/llvm-project/pull/236320
More information about the Mlir-commits
mailing list