[Mlir-commits] [mlir] [mlir][tosa] Add integer type conversion pass (PR #232853)

[Jack Frankland]

FranklandJack wrote:

> > I know the motivation here is primarily to handle i4 and i48 widening that originates in TOSA workloads but given that this pass is completely generic and deals with builtin types should we decouple this from TOSA completely?
> 
> I did consider that but it widens the contract more and means more cases to deal with. The example Codex kept warning me about was `arith.extsi %0 : i48 to i64` which becomes invalid if i48 is widened to i64 since that op requires that the input width is less than the output width. Currently I can say "don't care, not TOSA" but if the pass was intended to be generic then it would need to deal with specific issues like that.

Hmm okay, makes sense and I guess we'd have to consider future dialects/ops that had similar restrictions. 

https://github.com/llvm/llvm-project/pull/232853