[Mlir-commits] [mlir] e61c0f8 - [mlir][ArmSME][NFC] Include generated interface declarations outside of namespaces (#236106)

[llvmlistbot at llvm.org]

Author: Markus Böck
Date: 2026-10-27T13:29:51Z
New Revision: e61c0f8368ceb522113657456f6832f8dce703b2

URL: https://github.com/llvm/llvm-project/commit/e61c0f8368ceb522113657456f6832f8dce703b2
DIFF: https://github.com/llvm/llvm-project/commit/e61c0f8368ceb522113657456f6832f8dce703b2.diff

LOG: [mlir][ArmSME][NFC] Include generated interface declarations outside of namespaces (#236106)

`ArmSMETileOpInterface` now specifies its `cppNamespace` in ODS, so the
generated `ArmSMEOpInterfaces.h.inc` declares it in the right namespace
by itself. This allows including the generated header at global scope
instead of from within namespace `mlir::arm_sme`.

Added: 
    

Modified: 
    mlir/include/mlir/Dialect/ArmSME/IR/ArmSMEOpInterfaces.h
    mlir/include/mlir/Dialect/ArmSME/IR/ArmSMEOps.td

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Dialect/ArmSME/IR/ArmSMEOpInterfaces.h b/mlir/include/mlir/Dialect/ArmSME/IR/ArmSMEOpInterfaces.h
index 9153fbb57ea88e..a03a9353e49c3c 100644
--- a/mlir/include/mlir/Dialect/ArmSME/IR/ArmSMEOpInterfaces.h
+++ b/mlir/include/mlir/Dialect/ArmSME/IR/ArmSMEOpInterfaces.h
@@ -20,8 +20,8 @@ LogicalResult verifyArmSMETileOpInterface(Operation *);
 // The first in-memory SME tile ID. This is set to 16 as that is the first tile
 // ID larger than any virtual tile ID supported by the SME ISA.
 static constexpr unsigned kInMemoryTileIdBase = 16;
+} // namespace mlir::arm_sme
 
 #include "mlir/Dialect/ArmSME/IR/ArmSMEOpInterfaces.h.inc"
-} // namespace mlir::arm_sme
 
 #endif // MLIR_DIALECT_ARMSME_OPINTERFACES_H

diff  --git a/mlir/include/mlir/Dialect/ArmSME/IR/ArmSMEOps.td b/mlir/include/mlir/Dialect/ArmSME/IR/ArmSMEOps.td
index f7fec15ec130e7..10a32f19d89279 100644
--- a/mlir/include/mlir/Dialect/ArmSME/IR/ArmSMEOps.td
+++ b/mlir/include/mlir/Dialect/ArmSME/IR/ArmSMEOps.td
@@ -38,6 +38,7 @@ def ArmSMETileType : I32EnumAttr<"ArmSMETileType", "Arm SME tile type",
 }
 
 def ArmSMETileOpInterface : OpInterface<"ArmSMETileOpInterface"> {
+  let cppNamespace = "::mlir::arm_sme";
   let description = [{
     An interface for operations that use Arm SME tiles. These operations need to
     be assigned a tile ID, an i32 attribute, which specifies which virtual tile