[Mlir-commits] [mlir] [mlir][x86] Support multi-level unroll of contractions with non-native K extent (PR #234593)

[Adam Siemieniuk]

================
@@ -61,12 +61,19 @@ struct MLUCandidate {
   vector::TransferReadOp lhsRead;
   vector::TransferReadOp rhsRead;
 
+  // Distinguishes whether the IV of the accumulation loop is used to index a
+  // vector dimension ("offset") or a non-vector dimension ("block") on the
+  // operand transfer reads.
+  enum class IndexKind { Unknown, Offset, Block };
----------------
adam-smnk wrote:

I still don't fully follow the `Offset` vs `Block` distinction particularly as it's a singular field on contract op.
Wouldn't a B(R)GEMM style contraction potentially be both?
I guess that's partially the root cause of the above regression.

https://github.com/llvm/llvm-project/pull/234593