[Mlir-commits] [clang] [mlir] [CIR][mlir][ABI] Add IndirectAliased (byref) argument lowering (PR #230415)

[llvmlistbot at llvm.org]

================
@@ -159,6 +184,10 @@ computeNewReturnType(mlir::Type origRetTy, const ArgClassification &retInfo,
     emitError() << "Expand return is not allowed (classic codegen rejects "
                 << "it in EmitFunctionEpilog)";
     return nullptr;
+  case ArgKind::IndirectAliased:
+    emitError() << "IndirectAliased return is not allowed (classic codegen "
----------------
skc7 wrote:

Updated the comment, to drop the classic codegen part. Kept it as an error rather than `llvm_unreachable` because test target can inject this return kind, and with `llvm_unreachable` `cir-opt` crashes on `indirect-aliased-nyi.cir` instead of giving a diagnostic.

https://github.com/llvm/llvm-project/pull/230415