[Mlir-commits] [llvm] [mlir] [TableGen] Store template arguments separately from fields (PR #234933)

[Jay Foad]

jayfoad wrote:

> > getValues() now only returns
> > fields, so the code that skipped template arguments when inheriting,
> > instantiating, printing or dumping fields goes away. getValue() looks up
> > both fields and template arguments
> 
> It is confusing that two similarly named methods return different things. Rename getValues() to getFields()?

Good point but rather than renaming anything I've changed getValue() to only look up fields. (It's a small change and if anything it slightly simplifies the parser overall.) So now getValue/getValues consistently operate on fields and getTemplateArg/getTemplateArgs consistently operate on template args. WDYT?

https://github.com/llvm/llvm-project/pull/234933