[Mlir-commits] [mlir] [mlir][gpu] Split target-specific passes out of MLIRGPUTransforms (PR #234903)

Fri Oct 23 03:32:59 PDT 2026

github-actions[bot] wrote:




:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions h,cpp -- mlir/include/mlir/Dialect/GPU/Transforms/NVVM/Passes.h mlir/include/mlir/Dialect/GPU/Transforms/ROCDL/Passes.h mlir/include/mlir/Dialect/GPU/Transforms/SPIRV/Passes.h mlir/include/mlir/Dialect/GPU/Transforms/XeVM/Passes.h mlir/lib/Dialect/GPU/Transforms/ROCDL/SubgroupReduceToDPP.cpp mlir/include/mlir-c/Dialect/GPU.h mlir/include/mlir/Dialect/GPU/Transforms/Passes.h mlir/include/mlir/Dialect/GPU/Utils/GPUUtils.h mlir/lib/Bindings/Python/GPUPasses.cpp mlir/lib/CAPI/Dialect/GPUPasses.cpp mlir/lib/Conversion/GPUToROCDL/LowerGpuOpsToROCDLOps.cpp mlir/lib/Dialect/GPU/Pipelines/GPUToNVVMPipeline.cpp mlir/lib/Dialect/GPU/Pipelines/GPUToROCDLPipeline.cpp mlir/lib/Dialect/GPU/Pipelines/GPUToXeVMPipeline.cpp mlir/lib/Dialect/GPU/TransformOps/GPUTransformOps.cpp mlir/lib/Dialect/GPU/Transforms/SubgroupReduceLowering.cpp mlir/lib/Dialect/GPU/Utils/Utils.cpp mlir/lib/Dialect/SparseTensor/Pipelines/SparseTensorPipelines.cpp mlir/lib/RegisterAllPasses.cpp mlir/test/lib/Dialect/GPU/TestGpuRewrite.cpp mlir/test/lib/Pass/TestVulkanRunnerPipeline.cpp mlir/lib/Dialect/GPU/Transforms/NVVM/NVVMAttachTarget.cpp mlir/lib/Dialect/GPU/Transforms/ROCDL/PromoteShuffleToAMDGPU.cpp mlir/lib/Dialect/GPU/Transforms/ROCDL/ROCDLAttachTarget.cpp mlir/lib/Dialect/GPU/Transforms/SPIRV/SPIRVAttachTarget.cpp mlir/lib/Dialect/GPU/Transforms/XeVM/XeVMAttachTarget.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff

diff --git a/mlir/include/mlir-c/Dialect/GPU.h b/mlir/include/mlir-c/Dialect/GPU.h
index bc8d1dfc7..9c3dab86b 100644
--- a/mlir/include/mlir-c/Dialect/GPU.h
+++ b/mlir/include/mlir-c/Dialect/GPU.h
@@ -71,8 +71,8 @@ mlirGPUObjectAttrGetKernels(MlirAttribute mlirObjectAttr);
 }
 #endif
 
-#include "mlir/Dialect/GPU/Transforms/Passes.capi.h.inc"
 #include "mlir/Dialect/GPU/Transforms/NVVM/Passes.capi.h.inc"
+#include "mlir/Dialect/GPU/Transforms/Passes.capi.h.inc"
 #include "mlir/Dialect/GPU/Transforms/ROCDL/Passes.capi.h.inc"
 #include "mlir/Dialect/GPU/Transforms/SPIRV/Passes.capi.h.inc"
 #include "mlir/Dialect/GPU/Transforms/XeVM/Passes.capi.h.inc"
diff --git a/mlir/include/mlir/Dialect/GPU/Transforms/NVVM/Passes.h b/mlir/include/mlir/Dialect/GPU/Transforms/NVVM/Passes.h
index 0c79b7b03..5c5ec8181 100644
--- a/mlir/include/mlir/Dialect/GPU/Transforms/NVVM/Passes.h
+++ b/mlir/include/mlir/Dialect/GPU/Transforms/NVVM/Passes.h
@@ -17,14 +17,12 @@
 #include "mlir/Pass/Pass.h"
 
 namespace mlir {
-
 #define GEN_PASS_DECL
 #include "mlir/Dialect/GPU/Transforms/NVVM/Passes.h.inc"
 
 /// Generate the code for registering passes.
 #define GEN_PASS_REGISTRATION
 #include "mlir/Dialect/GPU/Transforms/NVVM/Passes.h.inc"
-
 } // namespace mlir
 
 #endif // MLIR_DIALECT_GPU_TRANSFORMS_NVVM_PASSES_H_
diff --git a/mlir/include/mlir/Dialect/GPU/Transforms/ROCDL/Passes.h b/mlir/include/mlir/Dialect/GPU/Transforms/ROCDL/Passes.h
index a3e596580..cfa1a3966 100644
--- a/mlir/include/mlir/Dialect/GPU/Transforms/ROCDL/Passes.h
+++ b/mlir/include/mlir/Dialect/GPU/Transforms/ROCDL/Passes.h
@@ -20,7 +20,6 @@
 #include <optional>
 
 namespace mlir {
-
 #define GEN_PASS_DECL
 #include "mlir/Dialect/GPU/Transforms/ROCDL/Passes.h.inc"
 
@@ -44,7 +43,6 @@ void populateGpuPromoteShuffleToAMDGPUPatterns(
 /// Generate the code for registering passes.
 #define GEN_PASS_REGISTRATION
 #include "mlir/Dialect/GPU/Transforms/ROCDL/Passes.h.inc"
-
 } // namespace mlir
 
 #endif // MLIR_DIALECT_GPU_TRANSFORMS_ROCDL_PASSES_H_
diff --git a/mlir/include/mlir/Dialect/GPU/Transforms/SPIRV/Passes.h b/mlir/include/mlir/Dialect/GPU/Transforms/SPIRV/Passes.h
index 94b60d0cc..ad9713374 100644
--- a/mlir/include/mlir/Dialect/GPU/Transforms/SPIRV/Passes.h
+++ b/mlir/include/mlir/Dialect/GPU/Transforms/SPIRV/Passes.h
@@ -17,14 +17,12 @@
 #include "mlir/Pass/Pass.h"
 
 namespace mlir {
-
 #define GEN_PASS_DECL
 #include "mlir/Dialect/GPU/Transforms/SPIRV/Passes.h.inc"
 
 /// Generate the code for registering passes.
 #define GEN_PASS_REGISTRATION
 #include "mlir/Dialect/GPU/Transforms/SPIRV/Passes.h.inc"
-
 } // namespace mlir
 
 #endif // MLIR_DIALECT_GPU_TRANSFORMS_SPIRV_PASSES_H_
diff --git a/mlir/include/mlir/Dialect/GPU/Transforms/XeVM/Passes.h b/mlir/include/mlir/Dialect/GPU/Transforms/XeVM/Passes.h
index 26b51550c..520e77e00 100644
--- a/mlir/include/mlir/Dialect/GPU/Transforms/XeVM/Passes.h
+++ b/mlir/include/mlir/Dialect/GPU/Transforms/XeVM/Passes.h
@@ -17,14 +17,12 @@
 #include "mlir/Pass/Pass.h"
 
 namespace mlir {
-
 #define GEN_PASS_DECL
 #include "mlir/Dialect/GPU/Transforms/XeVM/Passes.h.inc"
 
 /// Generate the code for registering passes.
 #define GEN_PASS_REGISTRATION
 #include "mlir/Dialect/GPU/Transforms/XeVM/Passes.h.inc"
-
 } // namespace mlir
 
 #endif // MLIR_DIALECT_GPU_TRANSFORMS_XEVM_PASSES_H_
diff --git a/mlir/lib/Dialect/GPU/Utils/Utils.cpp b/mlir/lib/Dialect/GPU/Utils/Utils.cpp
index 562d8a259..fe0deac62 100644
--- a/mlir/lib/Dialect/GPU/Utils/Utils.cpp
+++ b/mlir/lib/Dialect/GPU/Utils/Utils.cpp
@@ -67,5 +67,4 @@ getSubgroupReduceClusterInfo(SubgroupReduceOp op, unsigned subgroupSize) {
   return SubgroupReduceClusterInfo{clusterStride, effectiveClusterSize,
                                    subgroupSize};
 }
-
 } // namespace mlir::gpu

``````````

</details>


https://github.com/llvm/llvm-project/pull/234903
