[Mlir-commits] [mlir] [mlir] [arith] Combine op for select (PR #234818)

[Chuanqi Xu]

ChuanqiXu9 wrote:

> There's too much AI slop in this PR, I'll stop reviewing. There are many unrelated tests to the feature being introduced, but not enough tests about the feature. Comments are random, code assumes too much. Also it's not clear that the code is safe, but it's clear that the LLM generated code that fit a particular pattern, which is worrying.
> 
> Note, this isn't about the author (you have done good contributions so far) or the feature (I think it makes sense and would be a good addition to the project).
> 
> It's about the PR itself that is just not good enough. I recommend you start over, write it yourself and only use LLMs to make sure you're doing the right thing and writing enough tests.

Oh, it is my bad. I just noticed the second commit I pushed containing something I thought I've given up. I made some basic  mistake. Sorry. In the first version, I wrote the comments by myself and adjusted the structure. I admit I didn't take a close look at the tests. I took a quick look and thought it has a good coverage.

And I remove the bad version and I'll try to rewrote the test by myself.

Sorry again for my bad operation.

https://github.com/llvm/llvm-project/pull/234818