[Mlir-commits] [mlir] [mlir] [arith] Combine op for select (PR #234818)

[Renato Golin]

================
@@ -3128,6 +3130,119 @@ struct SelectToExtUI : public OpRewritePattern<arith::SelectOp> {
   }
 };
 
+///   select(c, F(a0, a1), F(b0, b1))
+///     -> F(select(c, a0, b0), select(c, a1, b1)).
+/// For a non-poison condition, each lane of F receives exactly the operands of
+/// the selected producer, so poison in the other producer remains masked. For
+/// a poison condition, the original result is poison; the replacement may
----------------
rengolin wrote:

Going on about poison here is an LLM side effect of asking it to fix the review comment. Please don't just dump comments, actually make them reasonable.

https://github.com/llvm/llvm-project/pull/234818