[Mlir-commits] [mlir] [mlir][LLVM] PromotableOpInterface for PtrToIntOp and IntToPtrOp (PR #234309)

[Tobias Gysi]

gysit wrote:

Can you check how this is handled in LLVM?

I am sceptic about this change since folding away int / ptr conversions is generally dangerous since the casts lose the provenance part of the pointer (see the discussion around the folding pattern). Things maybe safe here since the we have to remove all blocking uses. However, we may implement the PromotableOpInterface on more ops in the future and run into random bugs.

So if you really have to handle this case for some reason we should stick as closely as possible to what LLVM does.


https://github.com/llvm/llvm-project/pull/234309