[Mlir-commits] [mlir] [MLIR][LLVM] Preserve inline asm call attributes with operand_attrs (PR #233770)

[llvmlistbot at llvm.org]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir-llvm

Author: Arseniy Obolenskiy (aobolensk)

<details>
<summary>Changes</summary>



---
Full diff: https://github.com/llvm/llvm-project/pull/233770.diff


2 Files Affected:

- (modified) mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp (+1-1) 
- (modified) mlir/test/Target/LLVMIR/llvmir.mlir (+3) 


``````````diff
diff --git a/mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp b/mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp
index 7833d8857699ce..7c04a1e2a6d785 100644
--- a/mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp
+++ b/mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp
@@ -669,7 +669,7 @@ convertOperationImpl(Operation &opInst, llvm::IRBuilderBase &builder,
     if (inlineAsmOp.getConvergent())
       inst->addFnAttr(llvm::Attribute::Convergent);
     if (auto maybeOperandAttrs = inlineAsmOp.getOperandAttrs()) {
-      llvm::AttributeList attrList;
+      llvm::AttributeList attrList = inst->getAttributes();
       for (const auto &it : llvm::enumerate(*maybeOperandAttrs)) {
         Attribute attr = it.value();
         if (!attr)
diff --git a/mlir/test/Target/LLVMIR/llvmir.mlir b/mlir/test/Target/LLVMIR/llvmir.mlir
index 7d0fc4c5207086..6daf265a69fbe8 100644
--- a/mlir/test/Target/LLVMIR/llvmir.mlir
+++ b/mlir/test/Target/LLVMIR/llvmir.mlir
@@ -2273,6 +2273,9 @@ llvm.func @useInlineAsm(%arg0: i32, %arg1 : !llvm.ptr) {
   // CHECK-NEXT:  call i8 asm "foo", "=r,r"(i32 {{.*}}) #[[$CONVERGENT:.*]]
   %9 = llvm.inline_asm convergent "foo", "=r,r" %arg0 : (i32) -> i8
 
+  // CHECK-NEXT:  call void asm "", "*m"(ptr elementtype(ptr) %1) #[[$CONVERGENT]]
+  llvm.inline_asm convergent operand_attrs = [{elementtype = !llvm.ptr}] "", "*m" %arg1 : (!llvm.ptr) -> !llvm.void
+
   llvm.return
 }
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/233770