[Mlir-commits] [mlir] [NFC][mlir] Mark dump() methods with LLVM_DUMP_METHOD (PR #233398)
Mehdi Amini
llvmlistbot at llvm.org
Mon Oct 19 04:07:08 PDT 2026
joker-eph wrote:
I think the advice in the macro definition is one that we should follow:
```
/// Note that you should also surround dump() functions with
/// `#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)` so they do always
/// get stripped in release builds.
```
Also, can you trim down the PR description? I think a paragraph of three lines at most should be enough here.
https://github.com/llvm/llvm-project/pull/233398
More information about the Mlir-commits
mailing list