[Mlir-commits] [mlir] [mlir][vector] Combine the operation mask in -lower-vector-mask (PR #226128)

[Federico Bruzzone]

FedericoBruzzone wrote:

I thought about how we could proceed. Following up on the [Andrzej comment](https://github.com/llvm/llvm-project/pull/226128#issuecomment-5818914164).

The verifier of `vector.mask` accepts a maskable op that already has its own mask operand. E.g.,
```mlir
vector.mask %outer { vector.transfer_read %src[%i], %pad, %inner : ... }
```
The same holds for `vector.transfer_write` and `vector.gather`.

Now, in my view, we should reject this combination in the `vector.mask` verifier. We shouldn't neither (i) `AND` them or (ii) use one of the two (ideally `%outer`). Does it sound good?

(Partially related to #227821)


https://github.com/llvm/llvm-project/pull/226128