[Mlir-commits] [mlir] [mlir][DLTI] Introduce an operation interface for scoped DLTI queries (PR #232733)

[Mehdi Amini]

================

----------------
joker-eph wrote:

> FuncDialect and GPUDialect cannot emit v0 bytecode at all:

Sure, but those directs are not stable, as far as I know, so I'm not sure that back-deploying to older readers is a supported use case anyway. 

> Producers targeting older bytecode versions via writerConfig.setDesiredBytecodeVersion(...) (such as [stablehlo::serializePortableArtifact](https://github.com/openxla/stablehlo/blob/main/stablehlo/dialect/Serialization.cpp), which wraps vhlo.* ops in a top-level builtin.module) now emit builtin version 1

I don't think that's a bug? Emitting an older bytecode version is orthogonal to the dialect. 

> Calling builtinDialect->setVersion(BuiltinDialectVersion(0)) therefore omits the version header while still writing properties.dlti, producing corrupt bytecode that ModuleOp::readProperties misparses.

I think that should be fixed in https://github.com/llvm/llvm-project/pull/233149 ?


I need more time to look at 3, thanks for reporting.

https://github.com/llvm/llvm-project/pull/232733