[Mlir-commits] [mlir] [mlir][ArithToLLVM] Preserve defined signed remainder by -1 (PR #233161)

[llvmlistbot at llvm.org]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- mlir/lib/Conversion/ArithToLLVM/ArithToLLVM.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/mlir/lib/Conversion/ArithToLLVM/ArithToLLVM.cpp b/mlir/lib/Conversion/ArithToLLVM/ArithToLLVM.cpp
index 92df63663..263ccfd06 100644
--- a/mlir/lib/Conversion/ArithToLLVM/ArithToLLVM.cpp
+++ b/mlir/lib/Conversion/ArithToLLVM/ArithToLLVM.cpp
@@ -704,7 +704,7 @@ LogicalResult MulIExtendedOpLowering<ArithMulOp, IsSigned>::matchAndRewrite(
 
 LogicalResult
 RemSIOpLowering::matchAndRewrite(arith::RemSIOp op, OpAdaptor adaptor,
-                               ConversionPatternRewriter &rewriter) const {
+                                 ConversionPatternRewriter &rewriter) const {
   Type operandType = adaptor.getLhs().getType();
   if (!LLVM::isCompatibleType(operandType))
     return failure();
@@ -727,7 +727,7 @@ RemSIOpLowering::matchAndRewrite(arith::RemSIOp op, OpAdaptor adaptor,
     Value isMinusOne = LLVM::ICmpOp::create(
         rewriter, loc, LLVM::ICmpPredicate::eq, adaptor.getRhs(), minusOne);
     Value lhs = LLVM::SelectOp::create(rewriter, loc, isMinusOne, zero,
-                                      adaptor.getLhs());
+                                       adaptor.getLhs());
     auto remainder = LLVM::SRemOp::create(rewriter, loc, lhs, adaptor.getRhs());
     remainder->setDiscardableAttrs(op->getDiscardableAttrDictionary());
     return remainder;

``````````

</details>


https://github.com/llvm/llvm-project/pull/233161