[Mlir-commits] [mlir] [mlir][tosa] Emit a runtime assertion when lowering `tosa.pad` with negative padding (PR #232221)

[Federico Bruzzone]

================

----------------
FedericoBruzzone wrote:

Currently, the ODS limits to document the existing impl. We're not introducing anything related to this `-1` in this PR.
That said, if having `-1`, in general, as an "amount that is not known at compile time", or if there is execution semantics for it, I think it goes beyond the scope of this PR.

Don't get me wrong, I completely agree with you. And we could argue that using `-1` without an operational semantics attached raises lots of questions. But maybe this needs an RFC to remove/fix this `-1` as a "dynamic value".

What I'm wondering is, what should I do? I don't understand, genuinely speaking.



https://github.com/llvm/llvm-project/pull/232221