[Mlir-commits] [mlir] [mlir][tosa] Emit a runtime assertion when lowering `tosa.pad` with negative padding (PR #232221)

[Mehdi Amini]

================

----------------
joker-eph wrote:

>> . For a constant padding, the verifier accepts -1 as a
placeholder for an amount that is not known at compile time, in which case
the corresponding output dimension is dynamic.
> Which is true, right? 

I don't know if it's true...
This is why I'm asking for an explanation: I don't understand what it means.  I don't understand the execution semantics. Having a dynamic output dimension just means we don't know it statically, but we still need an execution semantic. Absent of this, I don't understand this whole thing. 

> But please, if you think we should explicitly obscure the -1 fact from the docs, I'm more than happy to remove it.

I don't want to obscure any fact: but where is this -1 fact coming from? 

https://github.com/llvm/llvm-project/pull/232221