[Mlir-commits] [mlir] [mlir][tosa] Move profile compliance metadata to static constexpr tables (PR #232857)

[Vitaly Buka]

================
@@ -9,12 +9,16 @@
 #ifndef MLIR_DIALECT_TOSA_TRANSFORMS_TOSAPROFILECOMPILANCE_H
 #define MLIR_DIALECT_TOSA_TRANSFORMS_TOSAPROFILECOMPILANCE_H
 
-#include <unordered_map>
+#include <cstdint>
+#include <optional>
+#include <utility>
 
 #include "mlir/Dialect/Tosa/IR/TargetEnv.h"
 #include "mlir/Dialect/Tosa/Transforms/Passes.h"
-
-#include "mlir/Support/TypeID.h"
+#include "llvm/ADT/ArrayRef.h"
+#include "llvm/ADT/SmallString.h"
+#include "llvm/ADT/SmallVector.h"
+#include "llvm/ADT/StringRef.h"
 
 using namespace mlir;
----------------
vitalybuka wrote:

It's preexisting, but unacceptable in a public header.
It pollutes the global namespace and your new classes also go into global namespace.

It should be:

```
namespace mlir {
namespace tosa {
// entire file
}
}
```

Can you please fix that before landing?

https://github.com/llvm/llvm-project/pull/232857