[Mlir-commits] [mlir] [mlir][tosa] Emit a runtime assertion when lowering `tosa.pad` with negative padding (PR #232221)

[Federico Bruzzone]

================

----------------
FedericoBruzzone wrote:

I could not find where it comes from. I think it's a deliberate impl detail. 
It is not in the TOSA spec, as we saw. 
The following is the `PadOp` verifier:
https://github.com/llvm/llvm-project/blob/6efd62d3b09c0fd1445cb7c4e75ec41a6081b80a/mlir/lib/Dialect/Tosa/IR/TosaOps.cpp?plain=1#L2404-L2409

> Where/how is the padding supplied dynamically? Can you show an example?

Maybe I didn't catch it. Is the following what you're looking for? https://github.com/llvm/llvm-project/pull/232221/changes#diff-50020475cc76ab4f329780a242cc5100a4fcae7796e114964ebfc393f57fad66R571



https://github.com/llvm/llvm-project/pull/232221