[Mlir-commits] [mlir] [mlir][SPIR-V] Model OpenCL sincos memory effects (PR #232017)

[Alexander Shaposhnikov]

alexander-shaposhnikov wrote:

The description is outdated. Initially, the test  was 
```
%sin = spirv.CL.sincos %x, %cosval : f32, !spirv.ptr<f32, Function> -> f32
 return
```
and left the sine result unused and checked that canonicalization retained sincos, since it must preserve the cosine write.

I then replaced that with a direct test using -test-side-effects, which checks that the operation reports a write specifically on cosval. Whether the sine result is used doesn’t affect this check. 

https://github.com/llvm/llvm-project/pull/232017