[Mlir-commits] [mlir] [mlir][scf] Fix front-peel unsigned loops with at most one iteration (PR #231542)

[llvmlistbot at llvm.org]

================

----------------
StarOne01 wrote:

> What happens when the loop is marked as "unsigned" but uses an index type? Does such an op verify? 

Unsigned index loops verify, I did run them through the transform op before submitting the patch.

> we generate affine.min and arith.index_cast below, which is incorrect for unsigned loops.

You're right that the code below is signed, so I'll bail out for unsigned loops in the shared function for now (with a TODO) and add a proper unsigned path in follow-ups.

Thanks for the heads up :)

https://github.com/llvm/llvm-project/pull/231542