[Mlir-commits] [mlir] [mlir][tosa] Lower MATMUL_T to Linalg (PR #222661)

[llvmlistbot at llvm.org]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp,h -- mlir/lib/Conversion/TosaToLinalg/TosaToLinalgUtils.h mlir/lib/Conversion/TosaToLinalg/TosaToLinalg.cpp mlir/lib/Conversion/TosaToLinalg/TosaToLinalgNamed.cpp mlir/lib/Conversion/TosaToLinalg/TosaToLinalgNamedPass.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/mlir/lib/Conversion/TosaToLinalg/TosaToLinalg.cpp b/mlir/lib/Conversion/TosaToLinalg/TosaToLinalg.cpp
index 63e9779e3..25b4b3607 100644
--- a/mlir/lib/Conversion/TosaToLinalg/TosaToLinalg.cpp
+++ b/mlir/lib/Conversion/TosaToLinalg/TosaToLinalg.cpp
@@ -10,8 +10,8 @@
 //
 //===----------------------------------------------------------------------===//
 
-#include "TosaToLinalgUtils.h"
 #include "mlir/Conversion/TosaToLinalg/TosaToLinalg.h"
+#include "TosaToLinalgUtils.h"
 #include "mlir/Dialect/Arith/IR/Arith.h"
 #include "mlir/Dialect/Arith/Utils/Utils.h"
 #include "mlir/Dialect/Index/IR/IndexOps.h"
@@ -1558,7 +1558,6 @@ mlir::tosa::prepareMatMulTOperands(PatternRewriter &rewriter, Location loc,
 }
 
 namespace {
-
 // Linalg has quantized matmul and batch matmul operations, but neither has a
 // transpose-B variant. Lower nonzero zero points separately to linalg.generic
 // so the reduction can accumulate (A - aZp) * (B - bZp).
diff --git a/mlir/lib/Conversion/TosaToLinalg/TosaToLinalgUtils.h b/mlir/lib/Conversion/TosaToLinalg/TosaToLinalgUtils.h
index ee2ce0aad..2bc56c043 100644
--- a/mlir/lib/Conversion/TosaToLinalg/TosaToLinalgUtils.h
+++ b/mlir/lib/Conversion/TosaToLinalg/TosaToLinalgUtils.h
@@ -17,7 +17,6 @@ namespace mlir {
 class PatternRewriter;
 
 namespace tosa {
-
 struct MatMulTOperands {
   Value a;
   Value b;
@@ -29,7 +28,6 @@ struct MatMulTOperands {
 MatMulTOperands prepareMatMulTOperands(PatternRewriter &rewriter, Location loc,
                                        Value a, Value b,
                                        RankedTensorType outputType);
-
 } // namespace tosa
 } // namespace mlir
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/222661