[Mlir-commits] [mlir] [mlir][vector] Document dimension kinds in `vector.contract` (NFC) (PR #230458)

[Andrzej Warzyński]

================

----------------
banach-space wrote:

The only external reference that I have found: https://github.com/tensorflow/tensorflow/blob/master/tensorflow/core/util/einsum_op_util.h#L28-L46

You can use it in the PR summary - personally I wouldn't add it in the code.

> BTW, if you prefer, I can simply close this PR and add these changes to the PR for the implementation.

I am fine with this being merged - you have provided plenty of very convincing references. I would add some docs to `ContractionOp::getBatchDimMap` and `ContractionOp::getContractingDimMap` - I think that repeating the definition of the batch and contracting dims is fine.

https://github.com/llvm/llvm-project/pull/230458