[Mlir-commits] [mlir] [mlir][IR] Add builtin OCP INT8 element type (PR #230479)

[Davide Grohmann]

davidegrohmann wrote:

> `SparseElementsAttr::getZeroAttr()` will also need to be updated ?
> 
> https://github.com/llvm/llvm-project/blob/478b33afd9fed5a8d6a18753ad4c6b3693104e3f/mlir/lib/IR/BuiltinAttributes.cpp#L1541-L1565

Yes, I missed that. Thanks for pointing it out. I found also other missing pieces.
I have expanded testing and solve all the issues discovered.

https://github.com/llvm/llvm-project/pull/230479