[Mlir-commits] [llvm] [mlir] [mlir][Arith] Move ceil/floor div expansion to ArithUtils. NFC (PR #231064)

[Andrzej Warzyński]

banach-space wrote:

> An alternative is to create another library for these patterns.

Yes, that is one option. Before that, I'd explore using `mlir/lib/Conversion/ArithCommon/`.  Currently it contains `AttrToLLVMConverter.cpp`, which does not sound very "common". CMakeLists.txt provides a re-naming suggestion:
https://github.com/llvm/llvm-project/blob/6e69e2fb94cb7a1bb633b03d002cae335d9232fb/mlir/lib/Conversion/ArithCommon/CMakeLists.txt?plain=1#L1

To summarise, I would do the following:
* Rename `mlir/lib/Conversion/ArithCommon/` as `mlir/lib/Conversion/ArithAttrToLLVM`
* Move the patterns from this PR to a _new_ library inside `mlir/lib/Conversion/ArithCommon/`.

That should address the dependencies issues that you want to fix and improve naming within `Arith`. Does it make sense to you?

https://github.com/llvm/llvm-project/pull/231064