[Mlir-commits] [llvm] [mlir] [mlir][Arith] Move ceil/floor div expansion to ArithUtils. NFC (PR #231064)

[Andrzej Warzyński]

banach-space wrote:

Thanks!

AFAIK, we never put MLIR patterns in "Utils" files and I would prefer for us to stick with that - for consistency and to follow [the principle of least surprise](https://en.wikipedia.org/wiki/Principle_of_least_astonishment) ("utils" != "patterns").

If these patterns are only used by `MLIRArithToLLVM`, then moving to `MLIRArithToLLVM` could be a good option. I am going to defer to `Arith` maintainer, @kuhar - could you take a look? Thank you!

https://github.com/llvm/llvm-project/pull/231064