[Mlir-commits] [mlir] [mlir][Vector] Promote buffers accessed via dynamic subviews and memref.copy (PR #217793)

[Andrzej Warzyński]

================
@@ -6,29 +6,46 @@
 //
 //===----------------------------------------------------------------------===//
 //
-// This file implements Mem2Reg-related interfaces that let a statically-shaped
-// memref be promoted into a single SSA value, provided every access to
-// the buffer is a whole-buffer read or write (or a whole-sub-region access of
-// such a buffer via a subview). With these models, Mem2Reg replaces the memory
-// slot with a vector value (*), threading it as the reaching definition:
+// This file implements Mem2Reg interfaces for promoting a memref to a single
----------------
banach-space wrote:

Rhere are no Mem2Reg interfaces and we shouldn't refer to something that does not exist :) Please rename to "Memory slot interfaces". 

I understand that your goal is to implement `mem2reg` and I think that it's useful to make that clear. But "Mem2Reg" interfaces is misleading.

https://github.com/llvm/llvm-project/pull/217793