[Mlir-commits] [mlir] [mlir][vector] Document dimension kinds in `vector.contract` (NFC) (PR #230458)
Federico Bruzzone
llvmlistbot at llvm.org
Fri Oct 9 09:01:21 PDT 2026
FedericoBruzzone wrote:
> Thanks for the documentation @FedericoBruzzone, this makes it clear.
While this terminology is ubiquitous in the codebase, I think that we should document it here :D
> Could we add a comment above the lowering methods pointing to this doc?
It's implicit from my POV. If you're working on `LowerVectorContract`, for instance, it's clear that sooner or later you'll have to read the documentation for `vector.contract`, right?
However, I'm working on a new PR to refactor `lowerParallel` and `lowerReduction` to avoid misleading.
https://github.com/llvm/llvm-project/pull/230458
More information about the Mlir-commits
mailing list