[Mlir-commits] [mlir] [mlir][LLVM] Verify llvm.invoke callees like llvm.call (PR #229954)

[Tobias Gysi]

================
@@ -1298,35 +1299,37 @@ static LogicalResult verifyOperandBundles(OpType &op) {
 
 LogicalResult CallOp::verify() { return verifyOperandBundles(*this); }
 
-LogicalResult CallOp::verifySymbolUses(SymbolTableCollection &symbolTable) {
-  if (failed(verifyCallOpVarCalleeType(*this)))
-    return failure();
-
+template <typename OpTy>
+static LogicalResult
+verifyCallOpSymbolUses(OpTy callOp, SymbolTableCollection &symbolTable) {
+  // Note: no variadic-callee-type check here. CallOp runs it in
+  // verifySymbolUses below; InvokeOp already runs it in verify().
----------------
gysit wrote:

Any chance we could move `verifyCallOpVarCalleeType` here by dropping it from the Invoke::verify? It feels nicer since below we seem to rely on it running before (line 1314). 

If it doesn't move I would move / merge this comment with the one on line 1314.

https://github.com/llvm/llvm-project/pull/229954