[Mlir-commits] [llvm] [mlir] [AArch64][RuntimeDyld] Handle far external symbols in COFF JIT code (PR #229719)

[llvmlistbot at llvm.org]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp,h -- mlir/unittests/ExecutionEngine/WindowsArm64.cpp llvm/lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldCOFFAArch64.h --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldCOFFAArch64.h b/llvm/lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldCOFFAArch64.h
index c674bdc65..bf8c8667a 100644
--- a/llvm/lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldCOFFAArch64.h
+++ b/llvm/lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldCOFFAArch64.h
@@ -159,7 +159,6 @@ public:
     return (Inst & 0x7FC00000) == 0x11000000;
   }
 
-
   std::tuple<uint64_t, uint64_t, uint64_t>
   generateRelocationStub(unsigned SectionID, StringRef TargetName,
                          uint64_t Offset, uint64_t RelType, uint64_t Addend,
diff --git a/mlir/unittests/ExecutionEngine/WindowsArm64.cpp b/mlir/unittests/ExecutionEngine/WindowsArm64.cpp
index f1e01b7ad..be6adf8ae 100644
--- a/mlir/unittests/ExecutionEngine/WindowsArm64.cpp
+++ b/mlir/unittests/ExecutionEngine/WindowsArm64.cpp
@@ -28,7 +28,6 @@
 using namespace mlir;
 
 namespace {
-
 constexpr uintptr_t FourGiB = uintptr_t{4} << 30;
 constexpr uintptr_t EightGiB = uintptr_t{8} << 30;
 
@@ -171,7 +170,6 @@ TEST(MLIRExecutionEngine, ConstructorsAndFarExternalAddressOnWindowsArm64) {
   jit.reset();
   EXPECT_EQ(DtorCount, 1);
 }
-
 } // namespace
 
 #endif // Windows/AArch64

``````````

</details>


https://github.com/llvm/llvm-project/pull/229719