[Mlir-commits] [mlir] [mlir][vector] Handle rank mismatch when unrolling broadcasts (PR #227351)

[purnima shrivastava]

purnima-nlp wrote:

> Makes sense, thank you for the fix!
> 
> As hinted by @FedericoBruzzone , it would be good to reformat the tests a bit. I've left some initial comments. Let's continue once those are implemented.
> 
> In general, please follow our guidelines: https://mlir.llvm.org/getting_started/TestingGuide/#test-formatting-best-practices (and other sections as well)
> 
> For this test, you could use the following as source of inspiration:
> 
> https://github.com/llvm/llvm-project/blob/41c3ac61a470d947d587c9556fcca878386fdfe0/mlir/test/Conversion/VectorToLLVM/vector-to-llvm.mlir?plain=1#L35-L47
> 
> Thank you again for contributing!

Thank you for the guidance and the example! I’ve reformatted the tests to follow the MLIR testing guidelines, moved the checks before the functions, simplified the FileCheck patterns, improved the variable names/comments, and kept coverage for all generated tiles. I also ran the Vector dialect tests and all 101 tests pass.

https://github.com/llvm/llvm-project/pull/227351