[Mlir-commits] [mlir] [mlir][SymbolTable] Handle unknown symbol users in SymbolUserMap (PR #227918)

[Mehdi Amini]

================
@@ -1076,6 +1082,12 @@ SymbolUserMap::SymbolUserMap(SymbolTableCollection &symbolTable,
 }
 
 bool SymbolUserMap::areAllUsesVisible(Operation *symbol) const {
+  for (Operation *parent = symbol->getParentOp(); parent;
+       parent = parent->getParentOp()) {
+    if (symbolTablesWithUnknownUsers.contains(parent)) {
+      return false;
+    }
+  }
----------------
joker-eph wrote:

Why are we walking through all the parents recursively when the `symbolTablesWithUnknownUsers` is empty?  Seems like a waste for the common case?

https://github.com/llvm/llvm-project/pull/227918