[Mlir-commits] [mlir] [mlir][linalg] Fix rank-reducing insert_slice vectorization writing to wrong dims (PR #226490)

[Andrzej Warzyński]

banach-space wrote:

> cc @Tim096: https://github.com/llvm/llvm-project/pull/221293 is about the same bug. This PR builds the write with a permutation map, as suggested there.

I've only really noticed this now. @dhairyashilRG, since you were aware that @Tim096 was already working on this, why open a separate PR rather than help review the existing one?

Please, next time, could you communicate your plans in the existing PR before pursuing an alternative implementation yourself? Reviewing and helping move another contributor's PR forward is a greatly appreciated and valuable way of contributing to OSS, and helps us avoid duplicating work.

@Tim096 , apologies for missing your PR. Could you take a look at this one and rebase your PR on top of it (i.e. the strides part). Thank you!

https://github.com/llvm/llvm-project/pull/226490