[Mlir-commits] [mlir] [mlir][MemRef] Move the implementation of Mem2Reg interface from Vector to MemRef (nfc) (PR #228459)

[Jianhui Li]

================

----------------
Jianhui-Li wrote:

Please move this part of comment regarding "memref.subview" out to the beginning of the same-named file under memref. 

//===----------------------------------------------------------------------===//
//
// This file implements the `memref.subview` part of the Mem2Reg promotion
// described in lib/Dialect/Vector/Transforms/MemorySlotOpInterfaceImpl.cpp:
//
//   * a static, same-rank `memref.subview` is exposed as a promotable sub-slice
//     alias of the buffer's slot (via `PromotableAliaserInterface`): a read of
//     the subview projects out of the vector value with
//     `vector.extract_strided_slice`, and a write into it composes back into
//     the value with `vector.insert_strided_slice`. This lets a buffer that is
//     only ever accessed through static subviews promote as well, with partial
//     and overlapping sub-writes composing in program order.
//
//===----------------------------------------------------------------------===//

https://github.com/llvm/llvm-project/pull/228459