[Mlir-commits] [mlir] [mlir][linalg] Hoist masked vector transfer pairs (PR #221481)

[Hugo Pompougnac]

qaco wrote:

> > @banach-space done!
> 
> The code and tests make sense, but I have to asks:
> 
>     * Group "singleton" tests together and add a high-level label to clearly mark them, similar to e.g. https://github.com/llvm/llvm-project/blob/63d15eed742076b33100a5051f27aece1287b104/mlir/test/Dialect/Linalg/hoist-redundant-vector-transfers.mlir?plain=1#L3-L8
>       .
> 
>     * Add large block comments in `hoistRedundantVectorTransfers` to clearly split two high-level cases: `vector.transfer_read` + (optional) `vector.transfer_write` vs (singleton) `vector.transfer_write`.
> 
> 
> Thanks!

Done @banach-space 

https://github.com/llvm/llvm-project/pull/221481