[Mlir-commits] [mlir] [mlir][NFC] Name external model files and functions after their interface (PR #238261)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Tue Nov 3 01:41:30 PST 2026 

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir-bufferization

Author: Markus Böck (zero9178)

<details>
<summary>Changes</summary>

Throughout MLIR, a header declaring `register<Interface>ExternalModels` is named `<Interface>Impl.h`, and a dedicated library is named `MLIR<Dialect><Interface>Impl`. Rename files and registration functions to follow this convention for consistency

---

Patch is 50.44 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/238261.diff


47 Files Affected:

- (renamed) mlir/include/mlir/Dialect/Arith/Extensions/ShardingInterfaceImpl.h (+4-4) 
- (renamed) mlir/include/mlir/Dialect/Bufferization/Extensions/ShardingInterfaceImpl.h (+4-4) 
- (renamed) mlir/include/mlir/Dialect/Func/Extensions/ShardingInterfaceImpl.h (+4-7) 
- (renamed) mlir/include/mlir/Dialect/Linalg/Extensions/ShardingInterfaceImpl.h (+4-4) 
- (renamed) mlir/include/mlir/Dialect/Linalg/Transforms/RuntimeVerifiableOpInterfaceImpl.h (+4-4) 
- (renamed) mlir/include/mlir/Dialect/Linalg/Transforms/SubsetOpInterfaceImpl.h (+4-4) 
- (modified) mlir/include/mlir/Dialect/MemRef/IR/MemorySlotInterfacesImpl.h (+2-1) 
- (modified) mlir/include/mlir/Dialect/MemRef/Transforms/MemorySlotInterfacesImpl.h (+1-1) 
- (renamed) mlir/include/mlir/Dialect/MemRef/Transforms/RuntimeVerifiableOpInterfaceImpl.h (+4-4) 
- (renamed) mlir/include/mlir/Dialect/Tensor/Extensions/ShardingInterfaceImpl.h (+4-7) 
- (renamed) mlir/include/mlir/Dialect/Tensor/Transforms/RuntimeVerifiableOpInterfaceImpl.h (+4-4) 
- (renamed) mlir/include/mlir/Dialect/Tensor/Transforms/SubsetOpInterfaceImpl.h (+4-4) 
- (renamed) mlir/include/mlir/Dialect/Tosa/Extensions/ShardingInterfaceImpl.h (+4-4) 
- (modified) mlir/include/mlir/Dialect/Vector/Transforms/MemorySlotInterfacesImpl.h (+1-1) 
- (modified) mlir/lib/Dialect/Arith/Extensions/AllExtensions.cpp (+1-1) 
- (modified) mlir/lib/Dialect/Arith/Extensions/CMakeLists.txt (+4-4) 
- (renamed) mlir/lib/Dialect/Arith/Extensions/ShardingInterfaceImpl.cpp (+2-2) 
- (modified) mlir/lib/Dialect/Bufferization/Extensions/AllExtensions.cpp (+1-1) 
- (modified) mlir/lib/Dialect/Bufferization/Extensions/CMakeLists.txt (+4-4) 
- (renamed) mlir/lib/Dialect/Bufferization/Extensions/ShardingInterfaceImpl.cpp (+2-2) 
- (modified) mlir/lib/Dialect/Func/Extensions/AllExtensions.cpp (+1-1) 
- (modified) mlir/lib/Dialect/Func/Extensions/CMakeLists.txt (+4-4) 
- (renamed) mlir/lib/Dialect/Func/Extensions/ShardingInterfaceImpl.cpp (+2-4) 
- (modified) mlir/lib/Dialect/Linalg/Extensions/AllExtensions.cpp (+1-1) 
- (modified) mlir/lib/Dialect/Linalg/Extensions/CMakeLists.txt (+4-4) 
- (renamed) mlir/lib/Dialect/Linalg/Extensions/ShardingInterfaceImpl.cpp (+2-2) 
- (modified) mlir/lib/Dialect/Linalg/Transforms/AllInterfaces.cpp (+1-1) 
- (modified) mlir/lib/Dialect/Linalg/Transforms/CMakeLists.txt (+2-2) 
- (renamed) mlir/lib/Dialect/Linalg/Transforms/RuntimeVerifiableOpInterfaceImpl.cpp (+2-2) 
- (renamed) mlir/lib/Dialect/Linalg/Transforms/SubsetOpInterfaceImpl.cpp (+2-2) 
- (modified) mlir/lib/Dialect/MemRef/IR/MemorySlotInterfacesImpl.cpp (+1-1) 
- (modified) mlir/lib/Dialect/MemRef/Transforms/CMakeLists.txt (+1-1) 
- (modified) mlir/lib/Dialect/MemRef/Transforms/MemorySlotInterfacesImpl.cpp (+1-1) 
- (renamed) mlir/lib/Dialect/MemRef/Transforms/RuntimeVerifiableOpInterfaceImpl.cpp (+2-2) 
- (modified) mlir/lib/Dialect/Tensor/Extensions/AllExtensions.cpp (+1-1) 
- (modified) mlir/lib/Dialect/Tensor/Extensions/CMakeLists.txt (+4-4) 
- (renamed) mlir/lib/Dialect/Tensor/Extensions/ShardingInterfaceImpl.cpp (+2-3) 
- (modified) mlir/lib/Dialect/Tensor/Transforms/BufferizableOpInterfaceImpl.cpp (+1-1) 
- (modified) mlir/lib/Dialect/Tensor/Transforms/CMakeLists.txt (+2-2) 
- (renamed) mlir/lib/Dialect/Tensor/Transforms/RuntimeVerifiableOpInterfaceImpl.cpp (+2-2) 
- (renamed) mlir/lib/Dialect/Tensor/Transforms/SubsetOpInterfaceImpl.cpp (+2-4) 
- (modified) mlir/lib/Dialect/Tosa/Extensions/AllExtensions.cpp (+1-1) 
- (modified) mlir/lib/Dialect/Tosa/Extensions/CMakeLists.txt (+4-4) 
- (renamed) mlir/lib/Dialect/Tosa/Extensions/ShardingInterfaceImpl.cpp (+2-2) 
- (modified) mlir/lib/Dialect/Vector/Transforms/MemorySlotInterfacesImpl.cpp (+2-1) 
- (modified) mlir/lib/RegisterAllDialects.cpp (+7-7) 
- (modified) mlir/lib/Transforms/GenerateRuntimeVerification.cpp (+1-1) 


``````````diff
diff --git a/mlir/include/mlir/Dialect/Arith/Extensions/ShardingExtensions.h b/mlir/include/mlir/Dialect/Arith/Extensions/ShardingInterfaceImpl.h
similarity index 65%
rename from mlir/include/mlir/Dialect/Arith/Extensions/ShardingExtensions.h
rename to mlir/include/mlir/Dialect/Arith/Extensions/ShardingInterfaceImpl.h
index 1d33acb5bb5f00..5946691fedf803 100644
--- a/mlir/include/mlir/Dialect/Arith/Extensions/ShardingExtensions.h
+++ b/mlir/include/mlir/Dialect/Arith/Extensions/ShardingInterfaceImpl.h
@@ -1,4 +1,4 @@
-//===- ShardingExtensions.h - Arith sharding extensions ---------*- C++ -*-===//
+//===- ShardingInterfaceImpl.h - Arith sharding models ----------*- C++ -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
@@ -6,8 +6,8 @@
 //
 //===----------------------------------------------------------------------===//
 
-#ifndef MLIR_DIALECT_ARITH_EXTENSIONS_SHARDINGEXTENSIONS_H_
-#define MLIR_DIALECT_ARITH_EXTENSIONS_SHARDINGEXTENSIONS_H_
+#ifndef MLIR_DIALECT_ARITH_EXTENSIONS_SHARDINGINTERFACEIMPL_H_
+#define MLIR_DIALECT_ARITH_EXTENSIONS_SHARDINGINTERFACEIMPL_H_
 
 namespace mlir {
 class DialectRegistry;
@@ -17,4 +17,4 @@ void registerShardingInterfaceExternalModels(DialectRegistry &registry);
 } // namespace arith
 } // namespace mlir
 
-#endif // MLIR_DIALECT_ARITH_EXTENSIONS_SHARDINGEXTENSIONS_H_
+#endif // MLIR_DIALECT_ARITH_EXTENSIONS_SHARDINGINTERFACEIMPL_H_
diff --git a/mlir/include/mlir/Dialect/Bufferization/Extensions/ShardingExtensions.h b/mlir/include/mlir/Dialect/Bufferization/Extensions/ShardingInterfaceImpl.h
similarity index 64%
rename from mlir/include/mlir/Dialect/Bufferization/Extensions/ShardingExtensions.h
rename to mlir/include/mlir/Dialect/Bufferization/Extensions/ShardingInterfaceImpl.h
index 0fefd54c0255f5..5ab6b8301902a3 100644
--- a/mlir/include/mlir/Dialect/Bufferization/Extensions/ShardingExtensions.h
+++ b/mlir/include/mlir/Dialect/Bufferization/Extensions/ShardingInterfaceImpl.h
@@ -1,4 +1,4 @@
-//===- ShardingExtensions.h -----------------------------------------------===//
+//===- ShardingInterfaceImpl.h - Bufferization sharding models --*- C++ -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
@@ -6,8 +6,8 @@
 //
 //===----------------------------------------------------------------------===//
 
-#ifndef MLIR_DIALECT_BUFFERIZATION_SHARDINGEXTENSIONS_H
-#define MLIR_DIALECT_BUFFERIZATION_SHARDINGEXTENSIONS_H
+#ifndef MLIR_DIALECT_BUFFERIZATION_EXTENSIONS_SHARDINGINTERFACEIMPL_H
+#define MLIR_DIALECT_BUFFERIZATION_EXTENSIONS_SHARDINGINTERFACEIMPL_H
 
 namespace mlir {
 class DialectRegistry;
@@ -19,4 +19,4 @@ void registerShardingInterfaceExternalModels(DialectRegistry &registry);
 } // namespace bufferization
 } // namespace mlir
 
-#endif // MLIR_DIALECT_BUFFERIZATION_SHARDINGEXTENSIONS_H
+#endif // MLIR_DIALECT_BUFFERIZATION_EXTENSIONS_SHARDINGINTERFACEIMPL_H
diff --git a/mlir/include/mlir/Dialect/Func/Extensions/ShardingExtensions.h b/mlir/include/mlir/Dialect/Func/Extensions/ShardingInterfaceImpl.h
similarity index 63%
rename from mlir/include/mlir/Dialect/Func/Extensions/ShardingExtensions.h
rename to mlir/include/mlir/Dialect/Func/Extensions/ShardingInterfaceImpl.h
index e22b24b3446bb6..7fc0ed8d8aff79 100644
--- a/mlir/include/mlir/Dialect/Func/Extensions/ShardingExtensions.h
+++ b/mlir/include/mlir/Dialect/Func/Extensions/ShardingInterfaceImpl.h
@@ -1,4 +1,4 @@
-//===- ShardingExtensions.h - -----------------------------------------===//
+//===- ShardingInterfaceImpl.h - Func sharding models -----------*- C++ -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
@@ -6,18 +6,15 @@
 //
 //===----------------------------------------------------------------------===//
 
-#ifndef MLIR_DIALECT_FUNC_IR_SHARDINGINTERFACEIMPL_H_
-#define MLIR_DIALECT_FUNC_IR_SHARDINGINTERFACEIMPL_H_
+#ifndef MLIR_DIALECT_FUNC_EXTENSIONS_SHARDINGINTERFACEIMPL_H_
+#define MLIR_DIALECT_FUNC_EXTENSIONS_SHARDINGINTERFACEIMPL_H_
 
 namespace mlir {
-
 class DialectRegistry;
 
 namespace func {
-
 void registerShardingInterfaceExternalModels(DialectRegistry &registry);
-
 } // namespace func
 } // namespace mlir
 
-#endif // MLIR_DIALECT_FUNC_IR_SHARDINGINTERFACEIMPL_H_
+#endif // MLIR_DIALECT_FUNC_EXTENSIONS_SHARDINGINTERFACEIMPL_H_
diff --git a/mlir/include/mlir/Dialect/Linalg/Extensions/ShardingExtensions.h b/mlir/include/mlir/Dialect/Linalg/Extensions/ShardingInterfaceImpl.h
similarity index 65%
rename from mlir/include/mlir/Dialect/Linalg/Extensions/ShardingExtensions.h
rename to mlir/include/mlir/Dialect/Linalg/Extensions/ShardingInterfaceImpl.h
index 1904c44f7d6df6..fa8b862c5ffb62 100644
--- a/mlir/include/mlir/Dialect/Linalg/Extensions/ShardingExtensions.h
+++ b/mlir/include/mlir/Dialect/Linalg/Extensions/ShardingInterfaceImpl.h
@@ -1,4 +1,4 @@
-//===- ShardingExtensions.h - Linalg sharding extensions --------*- C++ -*-===//
+//===- ShardingInterfaceImpl.h - Linalg sharding models ---------*- C++ -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
@@ -6,8 +6,8 @@
 //
 //===----------------------------------------------------------------------===//
 
-#ifndef MLIR_DIALECT_LINALG_EXTENSIONS_SHARDINGEXTENSIONS_H_
-#define MLIR_DIALECT_LINALG_EXTENSIONS_SHARDINGEXTENSIONS_H_
+#ifndef MLIR_DIALECT_LINALG_EXTENSIONS_SHARDINGINTERFACEIMPL_H_
+#define MLIR_DIALECT_LINALG_EXTENSIONS_SHARDINGINTERFACEIMPL_H_
 
 namespace mlir {
 class DialectRegistry;
@@ -17,4 +17,4 @@ void registerShardingInterfaceExternalModels(DialectRegistry &registry);
 } // namespace linalg
 } // namespace mlir
 
-#endif // MLIR_DIALECT_LINALG_EXTENSIONS_SHARDINGEXTENSIONS_H_
+#endif // MLIR_DIALECT_LINALG_EXTENSIONS_SHARDINGINTERFACEIMPL_H_
diff --git a/mlir/include/mlir/Dialect/Linalg/Transforms/RuntimeOpVerification.h b/mlir/include/mlir/Dialect/Linalg/Transforms/RuntimeVerifiableOpInterfaceImpl.h
similarity index 63%
rename from mlir/include/mlir/Dialect/Linalg/Transforms/RuntimeOpVerification.h
rename to mlir/include/mlir/Dialect/Linalg/Transforms/RuntimeVerifiableOpInterfaceImpl.h
index 6c3643f7835cbe..5555520ace2288 100644
--- a/mlir/include/mlir/Dialect/Linalg/Transforms/RuntimeOpVerification.h
+++ b/mlir/include/mlir/Dialect/Linalg/Transforms/RuntimeVerifiableOpInterfaceImpl.h
@@ -1,4 +1,4 @@
-//===- RuntimeOpVerification.h - Op Verification ----------------*- C++ -*-===//
+//===- RuntimeVerifiableOpInterfaceImpl.h - Op Verification -----*- C++ -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
@@ -6,8 +6,8 @@
 //
 //===----------------------------------------------------------------------===//
 
-#ifndef MLIR_DIALECT_LINALG_RUNTIMEOPVERIFICATION_H
-#define MLIR_DIALECT_LINALG_RUNTIMEOPVERIFICATION_H
+#ifndef MLIR_DIALECT_LINALG_TRANSFORMS_RUNTIMEVERIFIABLEOPINTERFACEIMPL_H
+#define MLIR_DIALECT_LINALG_TRANSFORMS_RUNTIMEVERIFIABLEOPINTERFACEIMPL_H
 
 namespace mlir {
 class DialectRegistry;
@@ -18,4 +18,4 @@ void registerRuntimeVerifiableOpInterfaceExternalModels(
 } // namespace linalg
 } // namespace mlir
 
-#endif // MLIR_DIALECT_LINALG_RUNTIMEOPVERIFICATION_H
+#endif // MLIR_DIALECT_LINALG_TRANSFORMS_RUNTIMEVERIFIABLEOPINTERFACEIMPL_H
diff --git a/mlir/include/mlir/Dialect/Linalg/Transforms/SubsetInsertionOpInterfaceImpl.h b/mlir/include/mlir/Dialect/Linalg/Transforms/SubsetOpInterfaceImpl.h
similarity index 65%
rename from mlir/include/mlir/Dialect/Linalg/Transforms/SubsetInsertionOpInterfaceImpl.h
rename to mlir/include/mlir/Dialect/Linalg/Transforms/SubsetOpInterfaceImpl.h
index 94b0fb25b50665..c4b432c0202a78 100644
--- a/mlir/include/mlir/Dialect/Linalg/Transforms/SubsetInsertionOpInterfaceImpl.h
+++ b/mlir/include/mlir/Dialect/Linalg/Transforms/SubsetOpInterfaceImpl.h
@@ -1,4 +1,4 @@
-//===- SubsetInsertionOpInterfaceImpl.h - Tensor subsets --------*- C++ -*-===//
+//===- SubsetOpInterfaceImpl.h - Tensor subsets -----------------*- C++ -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
@@ -6,8 +6,8 @@
 //
 //===----------------------------------------------------------------------===//
 
-#ifndef MLIR_DIALECT_LINALG_SUBSETINSERTIONOPINTERFACEIMPL_H
-#define MLIR_DIALECT_LINALG_SUBSETINSERTIONOPINTERFACEIMPL_H
+#ifndef MLIR_DIALECT_LINALG_TRANSFORMS_SUBSETOPINTERFACEIMPL_H
+#define MLIR_DIALECT_LINALG_TRANSFORMS_SUBSETOPINTERFACEIMPL_H
 
 namespace mlir {
 class DialectRegistry;
@@ -17,4 +17,4 @@ void registerSubsetOpInterfaceExternalModels(DialectRegistry &registry);
 } // namespace linalg
 } // namespace mlir
 
-#endif // MLIR_DIALECT_LINALG_SUBSETINSERTIONOPINTERFACEIMPL_H
+#endif // MLIR_DIALECT_LINALG_TRANSFORMS_SUBSETOPINTERFACEIMPL_H
diff --git a/mlir/include/mlir/Dialect/MemRef/IR/MemorySlotInterfacesImpl.h b/mlir/include/mlir/Dialect/MemRef/IR/MemorySlotInterfacesImpl.h
index ab862060b3af3c..00eacf38dd98a2 100644
--- a/mlir/include/mlir/Dialect/MemRef/IR/MemorySlotInterfacesImpl.h
+++ b/mlir/include/mlir/Dialect/MemRef/IR/MemorySlotInterfacesImpl.h
@@ -13,7 +13,8 @@ namespace mlir {
 class DialectRegistry;
 
 namespace memref {
-void registerDestructurableTypeExternalModels(DialectRegistry &registry);
+void registerDestructurableTypeInterfaceExternalModels(
+    DialectRegistry &registry);
 } // namespace memref
 } // namespace mlir
 
diff --git a/mlir/include/mlir/Dialect/MemRef/Transforms/MemorySlotInterfacesImpl.h b/mlir/include/mlir/Dialect/MemRef/Transforms/MemorySlotInterfacesImpl.h
index cb94ccf1a3541b..fff284533f5176 100644
--- a/mlir/include/mlir/Dialect/MemRef/Transforms/MemorySlotInterfacesImpl.h
+++ b/mlir/include/mlir/Dialect/MemRef/Transforms/MemorySlotInterfacesImpl.h
@@ -17,7 +17,7 @@ class Location;
 class OpBuilder;
 
 namespace memref {
-void registerMemorySlotOpInterfaceExternalModels(DialectRegistry &registry);
+void registerMemorySlotInterfacesExternalModels(DialectRegistry &registry);
 
 /// Returns whether `slotPtr` is a dynamic `memref.subview` that can be promoted
 /// as an alias of the whole parent vector.
diff --git a/mlir/include/mlir/Dialect/MemRef/Transforms/RuntimeOpVerification.h b/mlir/include/mlir/Dialect/MemRef/Transforms/RuntimeVerifiableOpInterfaceImpl.h
similarity index 63%
rename from mlir/include/mlir/Dialect/MemRef/Transforms/RuntimeOpVerification.h
rename to mlir/include/mlir/Dialect/MemRef/Transforms/RuntimeVerifiableOpInterfaceImpl.h
index df6ce9f10762be..e2d5d024fb33c2 100644
--- a/mlir/include/mlir/Dialect/MemRef/Transforms/RuntimeOpVerification.h
+++ b/mlir/include/mlir/Dialect/MemRef/Transforms/RuntimeVerifiableOpInterfaceImpl.h
@@ -1,4 +1,4 @@
-//===- RuntimeOpVerification.h - Op Verification ----------------*- C++ -*-===//
+//===- RuntimeVerifiableOpInterfaceImpl.h - Op Verification -----*- C++ -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
@@ -6,8 +6,8 @@
 //
 //===----------------------------------------------------------------------===//
 
-#ifndef MLIR_DIALECT_MEMREF_RUNTIMEOPVERIFICATION_H
-#define MLIR_DIALECT_MEMREF_RUNTIMEOPVERIFICATION_H
+#ifndef MLIR_DIALECT_MEMREF_TRANSFORMS_RUNTIMEVERIFIABLEOPINTERFACEIMPL_H
+#define MLIR_DIALECT_MEMREF_TRANSFORMS_RUNTIMEVERIFIABLEOPINTERFACEIMPL_H
 
 namespace mlir {
 class DialectRegistry;
@@ -18,4 +18,4 @@ void registerRuntimeVerifiableOpInterfaceExternalModels(
 } // namespace memref
 } // namespace mlir
 
-#endif // MLIR_DIALECT_MEMREF_RUNTIMEOPVERIFICATION_H
+#endif // MLIR_DIALECT_MEMREF_TRANSFORMS_RUNTIMEVERIFIABLEOPINTERFACEIMPL_H
diff --git a/mlir/include/mlir/Dialect/Tensor/Extensions/ShardingExtensions.h b/mlir/include/mlir/Dialect/Tensor/Extensions/ShardingInterfaceImpl.h
similarity index 62%
rename from mlir/include/mlir/Dialect/Tensor/Extensions/ShardingExtensions.h
rename to mlir/include/mlir/Dialect/Tensor/Extensions/ShardingInterfaceImpl.h
index 895e7e5939935e..06f2087e744e6e 100644
--- a/mlir/include/mlir/Dialect/Tensor/Extensions/ShardingExtensions.h
+++ b/mlir/include/mlir/Dialect/Tensor/Extensions/ShardingInterfaceImpl.h
@@ -1,4 +1,4 @@
-//===- ShardingExtensions.h - -------------------------------*- C++ -*-===//
+//===- ShardingInterfaceImpl.h - Tensor sharding models ---------*- C++ -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
@@ -6,18 +6,15 @@
 //
 //===----------------------------------------------------------------------===//
 
-#ifndef MLIR_DIALECT_TENSOR_EXTENSIONS_SHARDINGEXTENSIONS_H_
-#define MLIR_DIALECT_TENSOR_EXTENSIONS_SHARDINGEXTENSIONS_H_
+#ifndef MLIR_DIALECT_TENSOR_EXTENSIONS_SHARDINGINTERFACEIMPL_H_
+#define MLIR_DIALECT_TENSOR_EXTENSIONS_SHARDINGINTERFACEIMPL_H_
 
 namespace mlir {
-
 class DialectRegistry;
 
 namespace tensor {
-
 void registerShardingInterfaceExternalModels(DialectRegistry &registry);
-
 } // namespace tensor
 } // namespace mlir
 
-#endif // MLIR_DIALECT_TENSOR_EXTENSIONS_SHARDINGEXTENSIONS_H_
+#endif // MLIR_DIALECT_TENSOR_EXTENSIONS_SHARDINGINTERFACEIMPL_H_
diff --git a/mlir/include/mlir/Dialect/Tensor/Transforms/RuntimeOpVerification.h b/mlir/include/mlir/Dialect/Tensor/Transforms/RuntimeVerifiableOpInterfaceImpl.h
similarity index 63%
rename from mlir/include/mlir/Dialect/Tensor/Transforms/RuntimeOpVerification.h
rename to mlir/include/mlir/Dialect/Tensor/Transforms/RuntimeVerifiableOpInterfaceImpl.h
index 812c4dd6d2cb70..4bd936f45324bf 100644
--- a/mlir/include/mlir/Dialect/Tensor/Transforms/RuntimeOpVerification.h
+++ b/mlir/include/mlir/Dialect/Tensor/Transforms/RuntimeVerifiableOpInterfaceImpl.h
@@ -1,4 +1,4 @@
-//===- RuntimeOpVerification.h - Op Verification ----------------*- C++ -*-===//
+//===- RuntimeVerifiableOpInterfaceImpl.h - Op Verification -----*- C++ -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
@@ -6,8 +6,8 @@
 //
 //===----------------------------------------------------------------------===//
 
-#ifndef MLIR_DIALECT_TENSOR_RUNTIMEOPVERIFICATION_H
-#define MLIR_DIALECT_TENSOR_RUNTIMEOPVERIFICATION_H
+#ifndef MLIR_DIALECT_TENSOR_TRANSFORMS_RUNTIMEVERIFIABLEOPINTERFACEIMPL_H
+#define MLIR_DIALECT_TENSOR_TRANSFORMS_RUNTIMEVERIFIABLEOPINTERFACEIMPL_H
 
 namespace mlir {
 class DialectRegistry;
@@ -18,4 +18,4 @@ void registerRuntimeVerifiableOpInterfaceExternalModels(
 } // namespace tensor
 } // namespace mlir
 
-#endif // MLIR_DIALECT_TENSOR_RUNTIMEOPVERIFICATION_H
+#endif // MLIR_DIALECT_TENSOR_TRANSFORMS_RUNTIMEVERIFIABLEOPINTERFACEIMPL_H
diff --git a/mlir/include/mlir/Dialect/Tensor/Transforms/SubsetInsertionOpInterfaceImpl.h b/mlir/include/mlir/Dialect/Tensor/Transforms/SubsetOpInterfaceImpl.h
similarity index 63%
rename from mlir/include/mlir/Dialect/Tensor/Transforms/SubsetInsertionOpInterfaceImpl.h
rename to mlir/include/mlir/Dialect/Tensor/Transforms/SubsetOpInterfaceImpl.h
index 019da189a8c991..257e83f5599c77 100644
--- a/mlir/include/mlir/Dialect/Tensor/Transforms/SubsetInsertionOpInterfaceImpl.h
+++ b/mlir/include/mlir/Dialect/Tensor/Transforms/SubsetOpInterfaceImpl.h
@@ -1,4 +1,4 @@
-//===- SubsetInsertionOpInterfaceImpl.h - Tensor subsets ------------------===//
+//===- SubsetOpInterfaceImpl.h - Tensor subsets -----------------*- C++ -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
@@ -6,8 +6,8 @@
 //
 //===----------------------------------------------------------------------===//
 
-#ifndef MLIR_DIALECT_TENSOR_SUBSETINSERTIONOPINTERFACEIMPL_H
-#define MLIR_DIALECT_TENSOR_SUBSETINSERTIONOPINTERFACEIMPL_H
+#ifndef MLIR_DIALECT_TENSOR_TRANSFORMS_SUBSETOPINTERFACEIMPL_H
+#define MLIR_DIALECT_TENSOR_TRANSFORMS_SUBSETOPINTERFACEIMPL_H
 
 namespace mlir {
 class DialectRegistry;
@@ -17,4 +17,4 @@ void registerSubsetOpInterfaceExternalModels(DialectRegistry &registry);
 } // namespace tensor
 } // namespace mlir
 
-#endif // MLIR_DIALECT_TENSOR_SUBSETINSERTIONOPINTERFACEIMPL_H
+#endif // MLIR_DIALECT_TENSOR_TRANSFORMS_SUBSETOPINTERFACEIMPL_H
diff --git a/mlir/include/mlir/Dialect/Tosa/Extensions/ShardingExtensions.h b/mlir/include/mlir/Dialect/Tosa/Extensions/ShardingInterfaceImpl.h
similarity index 65%
rename from mlir/include/mlir/Dialect/Tosa/Extensions/ShardingExtensions.h
rename to mlir/include/mlir/Dialect/Tosa/Extensions/ShardingInterfaceImpl.h
index cd81fcde6188b1..f543a259bf2028 100644
--- a/mlir/include/mlir/Dialect/Tosa/Extensions/ShardingExtensions.h
+++ b/mlir/include/mlir/Dialect/Tosa/Extensions/ShardingInterfaceImpl.h
@@ -1,4 +1,4 @@
-//===- ShardingExtensions.h - Tosa sharding extensions ----------*- C++ -*-===//
+//===- ShardingInterfaceImpl.h - Tosa sharding models -----------*- C++ -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
@@ -6,8 +6,8 @@
 //
 //===----------------------------------------------------------------------===//
 
-#ifndef MLIR_DIALECT_TOSA_EXTENSIONS_SHARDINGEXTENSIONS_H_
-#define MLIR_DIALECT_TOSA_EXTENSIONS_SHARDINGEXTENSIONS_H_
+#ifndef MLIR_DIALECT_TOSA_EXTENSIONS_SHARDINGINTERFACEIMPL_H_
+#define MLIR_DIALECT_TOSA_EXTENSIONS_SHARDINGINTERFACEIMPL_H_
 
 namespace mlir {
 class DialectRegistry;
@@ -17,4 +17,4 @@ void registerShardingInterfaceExternalModels(DialectRegistry &registry);
 } // namespace tosa
 } // namespace mlir
 
-#endif // MLIR_DIALECT_TOSA_EXTENSIONS_SHARDINGEXTENSIONS_H_
+#endif // MLIR_DIALECT_TOSA_EXTENSIONS_SHARDINGINTERFACEIMPL_H_
diff --git a/mlir/include/mlir/Dialect/Vector/Transforms/MemorySlotInterfacesImpl.h b/mlir/include/mlir/Dialect/Vector/Transforms/MemorySlotInterfacesImpl.h
index 4a4095d8240222..5632406063fd09 100644
--- a/mlir/include/mlir/Dialect/Vector/Transforms/MemorySlotInterfacesImpl.h
+++ b/mlir/include/mlir/Dialect/Vector/Transforms/MemorySlotInterfacesImpl.h
@@ -13,7 +13,7 @@ namespace mlir {
 class DialectRegistry;
 
 namespace vector {
-void registerMemorySlotExternalModels(DialectRegistry &registry);
+void registerMemorySlotInterfacesExternalModels(DialectRegistry &registry);
 } // namespace vector
 } // namespace mlir
 
diff --git a/mlir/lib/Dialect/Arith/Extensions/AllExtensions.cpp b/mlir/lib/Dialect/Arith/Extensions/AllExtensions.cpp
index 2decf05edc8e21..42904ac8fd5107 100644
--- a/mlir/lib/Dialect/Arith/Extensions/AllExtensions.cpp
+++ b/mlir/lib/Dialect/Arith/Extensions/AllExtensions.cpp
@@ -7,7 +7,7 @@
 //===----------------------------------------------------------------------===//
 
 #include "mlir/Dialect/Arith/Extensions/AllExtensions.h"
-#include "mlir/Dialect/Arith/Extensions/ShardingExtensions.h"
+#include "mlir/Dialect/Arith/Extensions/ShardingInterfaceImpl.h"
 
 using namespace mlir;
 
diff --git a/mlir/lib/Dialect/Arith/Extensions/CMakeLists.txt b/mlir/lib/Dialect/Arith/Extensions/CMakeLists.txt
index 6a93ac8ab15542..8d6b0295690af6 100644
--- a/mlir/lib/Dialect/Arith/Extensions/CMakeLists.txt
+++ b/mlir/lib/Dialect/Arith/Extensions/CMakeLists.txt
@@ -1,10 +1,10 @@
 set(LLVM_OPTIONAL_SOURCES
   AllExtensions.cpp
-  ShardingExtensions.cpp
+  ShardingInterfaceImpl.cpp
   )
 
-add_mlir_extension_library(MLIRArithShardingExtensions
-  ShardingExtensions.cpp
+add_mlir_extension_library(MLIRArithShardingInterfaceImpl
+  ShardingInterfaceImpl.cpp
 
   ADDITIONAL_HEADER_DIRS
   ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/Arith/Extensions
@@ -23,5 +23,5 @@ add_mlir_extension_library(MLIRArithAllExtensions
   ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/Arith/Extensions
 
   LINK_LIBS PUBLIC
-  MLIRArithShardingExtensions
+  MLIRArithShardingInterfaceImpl
   )
diff --git a/mlir/lib/Dialect/Arith/Extensions/ShardingExtensions.cpp b/mlir/lib/Dialect/Arith/Extensions/ShardingInterfaceImpl.cpp
similarity index 97%
rename from mlir/lib/Dialect/Arith/Extensions/ShardingExtensions.cpp
rename to mlir/lib/Dialect/Arith/Extensions/ShardingInterfaceImpl.cpp
index e60d...
[truncated]

``````````

</details>


https://github.com/llvm/llvm-project/pull/238261

More information about the Mlir-commits mailing list