[Mlir-commits] [mlir] [mlir] Move sharding interface impls into extension libraries (PR #237987)

[Markus Böck]

================
@@ -1,23 +1,20 @@
-//===- ShardingInterfaceImpl.h - ------------------------------------------===//
+//===- ShardingExtensions.h - Arith sharding extensions ---------*- C++ -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
-#ifndef MLIR_DIALECT_ARITH_TRANSFORMS_SHARDINGINTERFACEIMPL_H_
-#define MLIR_DIALECT_ARITH_TRANSFORMS_SHARDINGINTERFACEIMPL_H_
+#ifndef MLIR_DIALECT_ARITH_EXTENSIONS_SHARDINGEXTENSIONS_H_
+#define MLIR_DIALECT_ARITH_EXTENSIONS_SHARDINGEXTENSIONS_H_
 
 namespace mlir {
-
 class DialectRegistry;
 
 namespace arith {
-
 void registerShardingInterfaceExternalModels(DialectRegistry &registry);
----------------
zero9178 wrote:

Good question, I tried to just follow the existing sharding registration conventions, but it seems the sharding models are not consistent with other upstream models.

I posted https://github.com/llvm/llvm-project/pull/238261 that should establish a consistent convention 

https://github.com/llvm/llvm-project/pull/237987