[Mlir-commits] [mlir] [mlir] Add searchable remark history and query-based links (PR #237762)

[Henrich Lauko]

================
@@ -139,13 +141,60 @@ struct RemarkOpts {
   inline RemarkOpts relatedTo(const detail::InFlightRemark &r) const;
 };
 
+/// Exact-match criteria for searching previously reported remarks. Unspecified
+/// fields match any value; a specified empty string matches an empty field.
+/// Strings are owned by the query. Locations belong to their MLIRContext and
+/// must not outlive it. A location match does not imply operation identity.
+class RemarkQuery {
----------------
xlauko wrote:

Every step in a chain copies all four std::optional<std::string>s. Adding &&-qualified overloads that return std::move(*this) would avoid that. Also, RemarkOpts starts with the static RemarkOpts::name(...), while this needs RemarkQuery().name(...). A static entry point would make the two read the same.

https://github.com/llvm/llvm-project/pull/237762