[Mlir-commits] [mlir] [mlir][tblgen] Error on unsubstituted $_self in op trait predicates (PR #227263)

[llvmlistbot at llvm.org]

LiRvs-Miria wrote:

Thanks — that makes sense. I'd like to take a shot at the mechanism-level fix myself: I'll spend some time getting familiar with the formatting layer (tgfmt/FmtContext and its callers, including the speculative uses that rely on the marker) and come back with a concrete proposal.

That'll take me a little while — I'm aiming for 1–2 weeks. One directional question in the meantime, so I don't study down the wrong path: is hard-erroring on unbound placeholders by default acceptable, with an explicit opt-out for speculative formatting like `canUniqueAttrConstraint`? Or would you prefer the diagnostic to stay non-fatal at the tgfmt level?

Happy to keep this PR open as the anchor in the meantime, or split it into a tracking issue + fresh patch — whichever you prefer.

https://github.com/llvm/llvm-project/pull/227263