[Mlir-commits] [mlir] [mlir][vector] Disallow pure reduction dims in vector.contract (PR #237709)

[Jianhui Li]

================
@@ -1140,6 +1140,25 @@ static LogicalResult verifyOutputShape(
   return success();
 }
 
+// Find a pure reduction dims, i.e. a reduction dim that is only
----------------
Jianhui-Li wrote:

"pure" reads to me like Pure trait (no side effects, speculatable). 
How about just use "getOneSidedReductionDim"?  Like you have a test named contraction_one_sided_reduction

https://github.com/llvm/llvm-project/pull/237709