[Mlir-commits] [mlir] [mlir][Func][EmitC] Bail-out to avoid errors from MemRef array conversions (PR #198583)

[ioana ghiban]

ioghiban wrote:

> > Added negative coverage under mlir/test/Dialect/EmitC/func rather than the narrower Conversion/FuncToEmitC tests because these cases exercise the composed -convert-to-emitc pipeline across multiple dialects:
> 
> To me it would make more sense to test via e.g. `-convert-func-to-emitc` and put the test in e.g. "mlir/test/Conversion/FuncToEmitC/unsupported.mlir" - this PR is basically helping documented what's not supported ATM.
> 
Tests are failing for `convert-func-to-emitc` (similarly for `convert-memref-...` and `convert-arith-...`, as the conversion bails out and `func.func`, `func.call`, and `func.return` are marked illegal. Therefore, errors are thrown. The purpose of this patch is to highlight conversion limitations with a smooth bail out mechanism, which is only possible via `convert-to-emitc`, which does not mark any ops illegal and accepts partial conversions.

https://github.com/llvm/llvm-project/pull/198583