[Mlir-commits] [mlir] [mlir][linalg] Fix getSourceSkipUnary to only skip cast-like ops (PR #198725)

[Hocky Yudhiono]

hockyy wrote:

> Good point. Would restricting to the cast ops that linalg.generalize produces (extsi/extui/extf/trunci/truncf/sitofp/uitofp) be the right scope, or do you have a more specific set in mind?

I'm thinking of creating a better way to let future benign unary operations to match it safely.
 
1. Definitely need to add a warning or a todo in that function, new elemwise unary ops can easily be added.
2. The name `getSourceSkipUnary` can be misleading, are there any call sites where skipping arbitrary unary ops that can change value is expected?
3. I believe this affects more than just `linalg.matmul` specialization right? 

https://github.com/llvm/llvm-project/pull/198725