[Mlir-commits] [mlir] [mlir][mem2reg] Promote memory slots through transparent view operations (PR #196924)

[Théo Degioanni]

================
@@ -534,17 +534,24 @@ MemorySlotPromotionAnalyzer::computeInfo() {
   // inherited from a nested region. As a side effect, `definingBlocks` contains
   // all regions with at least one store.
   //
-  // Iterating `info.userToBlockingUses` lets this also pick up stores that
-  // reach the slot through chains of aliases (`getPromotableSlotAliases`).
+  // Iterate over direct users of the slot pointer and all alias pointers in
+  // `info.aliasMap`. This assumes `PromotableMemOpInterface` operations storing
+  // to the slot use the slot pointer or its aliases directly. Dialects must
+  // implement `PromotableAliaserInterface` for views/aliasing, rather than
----------------
Moxinilian wrote:

I don't think the part of this comment about how not to do it is very relevant, with the aliaser interface it should now be obvious.

https://github.com/llvm/llvm-project/pull/196924