[Mlir-commits] [mlir] [mlir][spirv] Add SPIR-V NonSemantic.Graph.DebugInfo (PR #199519)

[llvmlistbot at llvm.org]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions h,cpp -- mlir/include/mlir/Target/SPIRV/SPIRVExtInstSets.h mlir/lib/Conversion/TosaToSPIRVTosa/TosaToSPIRVTosaPass.cpp mlir/lib/Target/SPIRV/Deserialization/DeserializeOps.cpp mlir/lib/Target/SPIRV/Deserialization/Deserializer.h mlir/lib/Target/SPIRV/Serialization/SerializeOps.cpp mlir/lib/Target/SPIRV/Serialization/Serializer.cpp mlir/lib/Target/SPIRV/Serialization/Serializer.h mlir/unittests/Dialect/SPIRV/DeserializationTest.cpp mlir/unittests/Dialect/SPIRV/SerializationTest.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/mlir/lib/Target/SPIRV/Deserialization/DeserializeOps.cpp b/mlir/lib/Target/SPIRV/Deserialization/DeserializeOps.cpp
index 54cd47716..487035821 100644
--- a/mlir/lib/Target/SPIRV/Deserialization/DeserializeOps.cpp
+++ b/mlir/lib/Target/SPIRV/Deserialization/DeserializeOps.cpp
@@ -450,9 +450,8 @@ spirv::Deserializer::processDebugInfoExtInst(ArrayRef<uint32_t> operands,
   }
   case spirv::GraphDebugInfoExtInst::DebugOperation: {
     if (operands.size() < 7)
-      return emitError(unknownLoc,
-                       "DebugOperation must have graph, string and "
-                       "instruction IDs");
+      return emitError(unknownLoc, "DebugOperation must have graph, string and "
+                                   "instruction IDs");
     auto &stringID = operands[5];
     FailureOr<Location> loc = getDebugLoc(stringID);
     if (failed(loc))
@@ -470,7 +469,8 @@ spirv::Deserializer::processDebugInfoExtInst(ArrayRef<uint32_t> operands,
   }
   case spirv::GraphDebugInfoExtInst::DebugTensor: {
     if (operands.size() < 6)
-      return emitError(unknownLoc, "DebugTensor must have tensor and string IDs");
+      return emitError(unknownLoc,
+                       "DebugTensor must have tensor and string IDs");
     auto &stringID = operands[5];
     auto &tensorID = operands[4];
     FailureOr<Location> loc = getDebugLoc(stringID);
diff --git a/mlir/lib/Target/SPIRV/Serialization/SerializeOps.cpp b/mlir/lib/Target/SPIRV/Serialization/SerializeOps.cpp
index 83341519f..0102a46dd 100644
--- a/mlir/lib/Target/SPIRV/Serialization/SerializeOps.cpp
+++ b/mlir/lib/Target/SPIRV/Serialization/SerializeOps.cpp
@@ -494,8 +494,7 @@ Serializer::encodeDebugInfoOperationInst(uint32_t debugGraphID,
   if (failed(encodeExtensionInstruction(
           nullptr, extDebugInfo,
           static_cast<uint32_t>(GraphDebugInfoExtInst::DebugOperation),
-          operands,
-          graphsDebugInfo)))
+          operands, graphsDebugInfo)))
     return failure();
 
   return success();
diff --git a/mlir/unittests/Dialect/SPIRV/DeserializationTest.cpp b/mlir/unittests/Dialect/SPIRV/DeserializationTest.cpp
index b485f5843..d3cc8dc8a 100644
--- a/mlir/unittests/Dialect/SPIRV/DeserializationTest.cpp
+++ b/mlir/unittests/Dialect/SPIRV/DeserializationTest.cpp
@@ -180,10 +180,10 @@ TEST_F(DeserializationTest, DebugInfoExtInstMissingOperands) {
   addInstruction(spirv::Opcode::OpExtInstImport, importOperands);
 
   uint32_t voidType = addVoidType();
-  addInstruction(spirv::Opcode::OpExtInst,
-                 {voidType, nextID++, extInstSetID,
-                  static_cast<uint32_t>(
-                      spirv::GraphDebugInfoExtInst::DebugTensor)});
+  addInstruction(
+      spirv::Opcode::OpExtInst,
+      {voidType, nextID++, extInstSetID,
+       static_cast<uint32_t>(spirv::GraphDebugInfoExtInst::DebugTensor)});
 
   ASSERT_FALSE(deserialize());
   expectDiagnostic("DebugTensor must have tensor and string IDs");
@@ -197,11 +197,11 @@ TEST_F(DeserializationTest, DebugOperationMissingInstructionIDs) {
   addInstruction(spirv::Opcode::OpExtInstImport, importOperands);
 
   uint32_t voidType = addVoidType();
-  addInstruction(spirv::Opcode::OpExtInst,
-                 {voidType, nextID++, extInstSetID,
-                  static_cast<uint32_t>(
-                      spirv::GraphDebugInfoExtInst::DebugOperation),
-                  /*debugGraphID=*/42, /*stringID=*/43});
+  addInstruction(
+      spirv::Opcode::OpExtInst,
+      {voidType, nextID++, extInstSetID,
+       static_cast<uint32_t>(spirv::GraphDebugInfoExtInst::DebugOperation),
+       /*debugGraphID=*/42, /*stringID=*/43});
 
   ASSERT_FALSE(deserialize());
   expectDiagnostic(

``````````

</details>


https://github.com/llvm/llvm-project/pull/199519