[Mlir-commits] [mlir] [mlir][linalg] Allow extra DPS inputs in convolution dim inference (PR #198462)

[Ahmad Tameem]

https://github.com/Tameem-10xE created https://github.com/llvm/llvm-project/pull/198462

As pointed out by @hanhanW in https://github.com/iree-org/iree/pull/24016#issuecomment-4444591355, this PR fixes a mismatch between `inferConvolutionDims` and the `LinalgConvolutionOpInterface` verifier. This is needed for quantized convolution ops, which can have extra scalar zero-point operands in addition to the input and filter operands.

>From 45262ed502b5024f32ededee90d361f6802a012c Mon Sep 17 00:00:00 2001
From: Tameem-10xE <ahmad.tameem at 10xengineers.ai>
Date: Mon, 18 May 2026 21:35:11 +0500
Subject: [PATCH] [mlir][linalg] Allow extra DPS inputs in convolution dim
 inference

Signed-off-by: Tameem-10xE <ahmad.tameem at 10xengineers.ai>
---
 mlir/lib/Dialect/Linalg/IR/LinalgInterfaces.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mlir/lib/Dialect/Linalg/IR/LinalgInterfaces.cpp b/mlir/lib/Dialect/Linalg/IR/LinalgInterfaces.cpp
index 2ba77cea8f16e..b761782541ff3 100644
--- a/mlir/lib/Dialect/Linalg/IR/LinalgInterfaces.cpp
+++ b/mlir/lib/Dialect/Linalg/IR/LinalgInterfaces.cpp
@@ -884,7 +884,7 @@ inferConvolutionDimsImpl(LinalgOp linalgOp,
 /// Returns a failure if `output_image` (and implicitly `filter_loop`) is empty.
 FailureOr<ConvolutionDimensions>
 mlir::linalg::inferConvolutionDims(LinalgOp linalgOp) {
-  if (linalgOp.getNumDpsInits() != 1 || linalgOp.getNumDpsInputs() != 2)
+  if (linalgOp.getNumDpsInits() != 1 || linalgOp.getNumDpsInputs() < 2)
     return failure();
 
   auto indexingMaps = linalgOp.getIndexingMapsArray();