[Mlir-commits] [mlir] [MLIR][XeGPU] Temporarily disable XeGPU peephole optimizer for CRI (PR #198031)

[llvmlistbot at llvm.org]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-mlir

@llvm/pr-subscribers-mlir-gpu

Author: Sang Ik Lee (silee2)

<details>
<summary>Changes</summary>

Temporarily disabling the optimization pass until a fix is ready.

---
Full diff: https://github.com/llvm/llvm-project/pull/198031.diff


1 Files Affected:

- (modified) mlir/lib/Dialect/XeGPU/Transforms/XeGPUPeepHoleOptimizer.cpp (+4-8) 


``````````diff
diff --git a/mlir/lib/Dialect/XeGPU/Transforms/XeGPUPeepHoleOptimizer.cpp b/mlir/lib/Dialect/XeGPU/Transforms/XeGPUPeepHoleOptimizer.cpp
index efe8e23978e91..77a7d8d04c9f6 100644
--- a/mlir/lib/Dialect/XeGPU/Transforms/XeGPUPeepHoleOptimizer.cpp
+++ b/mlir/lib/Dialect/XeGPU/Transforms/XeGPUPeepHoleOptimizer.cpp
@@ -257,10 +257,8 @@ class XeGPUCreateNdDescOpPattern final
     auto chipStr = xegpu::getChipStr(createNdOp);
     // Check if the chip is supported.
     assert(chipStr &&
-           (chipStr.value() == "pvc" || chipStr.value() == "bmg" ||
-            chipStr.value() == "cri") &&
-           "Expecting target chip to be pvc, bmg or cri for transpose "
-           "optimization.");
+           (chipStr.value() == "pvc" || chipStr.value() == "bmg") &&
+           "Expecting target chip to be pvc, bmg for transpose optimization.");
     const uArch *targetuArch = xegpu::uArch::getUArch(chipStr.value());
 
     auto convertType = tryOptimize(tdescTy, targetuArch);
@@ -574,14 +572,12 @@ struct XeGPUPeepHoleOptimizerPass final
     bool isTargetSupported = false;
     getOperation()->walk([&](gpu::GPUFuncOp funcOp) {
       auto chipStr = xegpu::getChipStr(funcOp);
-      if (chipStr && (chipStr.value() == "pvc" || chipStr.value() == "bmg" ||
-                      chipStr.value() == "cri"))
+      if (chipStr && (chipStr.value() == "pvc" || chipStr.value() == "bmg"))
         isTargetSupported = true;
     });
 
     if (!isTargetSupported) {
-      DBGS() << "XeGPUPeepHoleOptimizerPass only supports PVC, BMG and CRI "
-                "targets."
+      DBGS() << "XeGPUPeepHoleOptimizerPass only supports PVC, BMG targets."
              << "\n";
       return;
     }

``````````

</details>


https://github.com/llvm/llvm-project/pull/198031