[Mlir-commits] [mlir] ActionHandler getter (PR #197230)
Andrei Golubev
llvmlistbot at llvm.org
Wed May 13 02:38:47 PDT 2026
================
----------------
andrey-golubev wrote:
we were thinking that a test can be:
a) protection against deletion - someone decides to delete the getter, they'd need to delete the test, but they'd probably look at it first and see that downstream project uses the getter
b) if handler's type changes (e.g. someone decides to switch from std::function to a class), these tests could be the first place to see how the new API would work (from set / get / implicit use perspectives)
but i don't have a strong preference overall personally
https://github.com/llvm/llvm-project/pull/197230
More information about the Mlir-commits
mailing list