[Mlir-commits] [mlir] experimental vector contract (PR #194536)

[llvmlistbot at llvm.org]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions h,cpp -- mlir/include/mlir/Dialect/Vector/Transforms/LoweringPatterns.h mlir/lib/Dialect/Vector/Transforms/LowerVectorContract.cpp mlir/test/lib/Dialect/Vector/TestVectorTransforms.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/mlir/include/mlir/Dialect/Vector/Transforms/LoweringPatterns.h b/mlir/include/mlir/Dialect/Vector/Transforms/LoweringPatterns.h
index 0c3f82687..5dd9f1913 100644
--- a/mlir/include/mlir/Dialect/Vector/Transforms/LoweringPatterns.h
+++ b/mlir/include/mlir/Dialect/Vector/Transforms/LoweringPatterns.h
@@ -59,23 +59,19 @@ using FilterConstraintType = std::function<LogicalResult(ContractionOp op)>;
 LogicalResult defaultFilter(ContractionOp op);
 
 void populateVectorContractToDotPatterns(
-    RewritePatternSet &patterns,
-    FilterConstraintType filter = defaultFilter,
+    RewritePatternSet &patterns, FilterConstraintType filter = defaultFilter,
     PatternBenefit benefit = 1);
 
 void populateVectorContractToOuterProductPatterns(
-    RewritePatternSet &patterns,
-    FilterConstraintType filter = defaultFilter,
+    RewritePatternSet &patterns, FilterConstraintType filter = defaultFilter,
     PatternBenefit benefit = 1);
 
 void populateVectorContractToParallelArithPatterns(
-    RewritePatternSet &patterns,
-    FilterConstraintType filter = defaultFilter,
+    RewritePatternSet &patterns, FilterConstraintType filter = defaultFilter,
     PatternBenefit benefit = 1);
 
 void populateVectorContractGenericLoweringPatterns(
-    RewritePatternSet &patterns,
-    FilterConstraintType filter = defaultFilter,
+    RewritePatternSet &patterns, FilterConstraintType filter = defaultFilter,
     PatternBenefit benefit = 1);
 
 void populateVectorContractLoweringPatterns(
diff --git a/mlir/lib/Dialect/Vector/Transforms/LowerVectorContract.cpp b/mlir/lib/Dialect/Vector/Transforms/LowerVectorContract.cpp
index 9ae75fc54..7ed4731f2 100644
--- a/mlir/lib/Dialect/Vector/Transforms/LowerVectorContract.cpp
+++ b/mlir/lib/Dialect/Vector/Transforms/LowerVectorContract.cpp
@@ -301,10 +301,9 @@ class ContractionOpGenericLowering
 public:
   using MaskableOpRewritePattern::MaskableOpRewritePattern;
 
-  ContractionOpGenericLowering(
-      MLIRContext *context,
-      FilterConstraintType constraint = defaultFilter,
-      PatternBenefit benefit = 1)
+  ContractionOpGenericLowering(MLIRContext *context,
+                               FilterConstraintType constraint = defaultFilter,
+                               PatternBenefit benefit = 1)
       : MaskableOpRewritePattern<vector::ContractionOp>(context, benefit),
         filter(std::move(constraint)) {}
 
@@ -751,10 +750,9 @@ struct ContractOpToElementwise
     : public MaskableOpRewritePattern<vector::ContractionOp> {
   using MaskableOpRewritePattern::MaskableOpRewritePattern;
 
-  ContractOpToElementwise(
-      vector::VectorContractLowering vectorContractLowering,
-      MLIRContext *context, PatternBenefit benefit = 1,
-      FilterConstraintType constraint = defaultFilter)
+  ContractOpToElementwise(vector::VectorContractLowering vectorContractLowering,
+                          MLIRContext *context, PatternBenefit benefit = 1,
+                          FilterConstraintType constraint = defaultFilter)
       : MaskableOpRewritePattern<vector::ContractionOp>(context, benefit),
         vectorContractLowering(vectorContractLowering),
         filter(std::move(constraint)) {}
@@ -1251,10 +1249,7 @@ public:
 
 } // namespace
 
-LogicalResult
-mlir::vector::defaultFilter(ContractionOp) {
-  return success();
-}
+LogicalResult mlir::vector::defaultFilter(ContractionOp) { return success(); }
 
 void mlir::vector::populateVectorContractToDotPatterns(
     RewritePatternSet &patterns, FilterConstraintType filter,
diff --git a/mlir/test/lib/Dialect/Vector/TestVectorTransforms.cpp b/mlir/test/lib/Dialect/Vector/TestVectorTransforms.cpp
index e9899f7a5..11b408a74 100644
--- a/mlir/test/lib/Dialect/Vector/TestVectorTransforms.cpp
+++ b/mlir/test/lib/Dialect/Vector/TestVectorTransforms.cpp
@@ -178,10 +178,10 @@ struct TestVectorContractLoweringComposition final
             return success(!parentFunctionNameContains(op, "dot_reject"));
           },
           PatternBenefit(3));
-      populateVectorContractToOuterProductPatterns(
-          patterns, defaultFilter, PatternBenefit(2));
-      populateVectorContractGenericLoweringPatterns(
-          patterns, defaultFilter, PatternBenefit(1));
+      populateVectorContractToOuterProductPatterns(patterns, defaultFilter,
+                                                   PatternBenefit(2));
+      populateVectorContractGenericLoweringPatterns(patterns, defaultFilter,
+                                                    PatternBenefit(1));
     } else if (mode == "generic") {
       populateVectorContractGenericLoweringPatterns(patterns);
     } else if (mode == "parallel-arith") {

``````````

</details>


https://github.com/llvm/llvm-project/pull/194536