[Mlir-commits] [mlir] [mlir][vector] Migrate drop-lead-unit-dim to shape_cast (PR #196206)

[Andrzej Warzyński]

================
@@ -331,6 +393,16 @@ struct CastAwayTransferWriteLeadingOneDim
 
 } // namespace
 
+namespace {
+struct ContractionOperandDropInfo {
+  AffineMap map;
+  bool needsShapeCast = false;
+  bool transposeNeeded = false;
+  bool transposeNonOuterUnitDims = false;
+  SmallVector<int64_t> permutation;
+};
----------------
banach-space wrote:

* What is `ContractionOperandDropInfo` meant to mean? Drop what?
* `needsShapeCast` vs `transposeNeeded` - these names are inconsistent. 

In general, I am confused by this naming. IIUC, `needsShapeCast` encodes _how_ to drop a leading unit dim, right? But that's an implementation detail. The high-level info that's important is whether we need to drop a leading unit dim, right?

https://github.com/llvm/llvm-project/pull/196206